Petr Horáček has posted comments on this change.

Change subject: net: tests: support iperf3 for performance tests
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/46448/2/tests/nettestlib.py
File tests/nettestlib.py:

Line 31: from nose.plugins.skip import SkipTest
Line 32: import time
Line 33: 
Line 34: from vdsm.constants import EXT_BRCTL, EXT_TC, EXT_IPERF3
Line 35: from vdsm.ipwrapper import addrAdd, linkSet, linkAdd, linkDel, 
IPRoute2Error, \
place imports between parentheses
Line 36:     netns_add, netns_delete
Line 37: from vdsm.netlink import monitor
Line 38: from vdsm.utils import (execCmd, random_iface_name, pgrep, 
kill_and_rm_pid,
Line 39:                         CommandPath)


Line 269: 
Line 270: class IperfClient(_Iperf):
Line 271:     def __init__(self, server_ip, bind_to, test_time, threads=1):
Line 272:         """the client generate a machine readable json output that is 
set in
Line 273:         _raw_output upon completion, ANd can be read using the 'out' 
property.
and
Line 274:         server_ip: the ip of the corresponding iperf server
Line 275:         bind_to: IP address of the client
Line 276:         test_time: in seconds
Line 277:         """


-- 
To view, visit https://gerrit.ovirt.org/46448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to