Ondřej Svoboda has posted comments on this change. Change subject: net: tests: support iperf3 for performance tests ......................................................................
Patch Set 5: Code-Review-1 (6 comments) https://gerrit.ovirt.org/#/c/46448/5/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 120: EXT_IPERF3 = '@IPERF3_PATH@' Dan dislikes constants.py and we are phasing them out (but with no replacement for IPERF3_PATH, so the path will have to be repeated, although configure.ac exports it). https://gerrit.ovirt.org/#/c/46448/5/tests/nettestlib.py File tests/nettestlib.py: Line 39: CommandPath You might want to list classes earlier than functions in import statements. Line 42: EXT_IPERF3 /usr/bin/iperf3 will have to be repeated here. Line 272: """the client """ The client ... Line 273: And and Line 384: EXT_IPERF3 _IPERF3_BINARY.cmd -- To view, visit https://gerrit.ovirt.org/46448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
