Piotr Kliczewski has posted comments on this change. Change subject: ssl: ssl socket may throw sslerror during reading ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46625/1/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 122: self.handle_close() Line 123: return '' Line 124: else: Line 125: raise Line 126: except SSL.SSLError: > Is it always a fatal error meaning the socket is closed or need to be close This is really wired behavior of m2c. When the socket is closed in not very nice way we get SSLError with "unexpected eof". We can do anything about it than making sure that we release fd properly. Line 127: self.handle_close() Line 128: Line 129: def send(self, data): Line 130: try: -- To view, visit https://gerrit.ovirt.org/46625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8de60d91f81b08e9cb78df07f09d2bcc903c1bad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
