Nir Soffer has posted comments on this change. Change subject: ssl: ssl socket may throw sslerror during reading ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46625/1/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 123: return '' Line 124: else: Line 125: raise Line 126: except SSL.SSLError: Line 127: self.handle_close() The only problem I see is not logging the error. This may be always "unexpected eof", or something else, and we can never know or debug this error if we don't log them. I think the safest solution would be to log an error and close the socket. Also, this should return '' like the other branches - if the calling code is waiting for '' as a sign for closed socket, it may fail when you return None. Does this fix any bug, or just makes the code easier to work with? I would not rush with this change. Line 128: Line 129: def send(self, data): Line 130: try: Line 131: result = self.socket.send(data) -- To view, visit https://gerrit.ovirt.org/46625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8de60d91f81b08e9cb78df07f09d2bcc903c1bad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
