Yaniv Bronhaim has posted comments on this change. Change subject: Move load_needed_modules to vdsm-tool ......................................................................
Patch Set 7: (1 inline comment) .................................................... File vdsm-tool/load_needed_modules.py.in Line 42: def _enable_bond_dev(): Line 43: REQUIRED = set(['bond0', 'bond1', 'bond2', 'bond3', 'bond4']) Line 44: MASTER_FILE = '/sys/class/net/bonding_masters' Line 45: Line 46: # RHEV-M currently assumes that all bonding devices pre-exist This is py.in file, means that during 'make' we create new py file from this template that contain the same text and replace every sign that looks like @something@ with the value set in the file 'configure' (located in main vdsm folder), as in constant.py.in and all other 'in' files Line 47: existing = set(file(MASTER_FILE).read().split()) Line 48: with open(MASTER_FILE) as f: Line 49: for bond in REQUIRED - existing: Line 50: f.write('+%s\n' % bond) -- To view, visit http://gerrit.ovirt.org/7487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdc8f9d07a7150c4a846228811d6c5dcb17fa358 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao <we...@linux.vnet.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Wenyi Gao <we...@linux.vnet.ibm.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches