Alona Kaplan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2011: self.log.info("Hotplug NIC xml: %s", nicXml) Line 2012: Line 2013: try: Line 2014: if nic.is_hostdevice: Line 2015: hostdev.detach_detachable(params[hwclass.HOSTDEV]) > Traceback (most recent call last): jsonrpc.Executor/7::DEBUG::2015-12-14 17:57:49,571::__init__::509::jsonrpc.JsonRpcServer::(_serveRequest) Calling 'VM.hotplugNic' in bridge with {'params': {'nic': {'macAddr': '00:1a:4a:16:01:52', 'specParams': {}, 'hostdev': 'pci_0000_02_10_2', 'deviceId': '926beebb-2389-42f5-b9ae-a1ab1ff56257', 'device': 'hostdev', 'type': 'interface'}, 'vmId': '5265b214-52b9-4bfe-b661-c81c19e77df8'}, 'vmID': '5265b214-52b9-4bfe-b661 -c81c19e77df8'} jsonrpc.Executor/7::DEBUG::2015-12-14 17:57:49,584::utils::645::root::(execCmd) /usr/bin/taskset --cpu-list 0-7 /usr/libexec/vdsm/hooks/before_nic_hotplug/50_vmfex (cwd None) jsonrpc.Executor/7::DEBUG::2015-12-14 17:57:49,703::utils::663::root::(execCmd) SUCCESS: <err> = ''; <rc> = 0 jsonrpc.Executor/7::INFO::2015-12-14 17:57:49,704::hooks::101::root::(_runHooksDir) jsonrpc.Executor/7::INFO::2015-12-14 17:57:49,704::vm::2011::virt.vm::(hotplugNic) vmId=`5265b214-52b9-4bfe-b661-c81c19e77df8`::Hotplug NIC xml: <interface managed="no" type="hostdev"> <mac address="00:1a:4a:16:01:52"/> <source> <address bus="2" domain="0" function="2" slot="16" type="pci"/> </source> <driver name="vfio"/> </interface> Line 2016: self._dom.attachDevice(nicXml) Line 2017: except libvirt.libvirtError as e: Line 2018: self.log.exception("Hotplug failed") Line 2019: nicXml = hooks.after_nic_hotplug_fail( -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
