Dan Kenigsberg has posted comments on this change. Change subject: untested: notify Engine when host connectivity changes ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51135/1/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 561: |net|host_conn| > I think that we need more descriptive subscription id. We need to know on t Isn't Engine already aware of where the event is originating? Vdsm is not aware of Engine's host-id for it. And yes, we need to discuss with Engine whether we should send the data now, or just trigger a getCapabilities call. -- To view, visit https://gerrit.ovirt.org/51135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
