Martin Mucha has posted comments on this change. Change subject: untested: notify Engine when host connectivity changes ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51135/1/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 561: |net|host_conn| > Engine is aware from which vdsm is it. I talked to Martin and we agreed on I just tried it with "|net|host_conn|no_id" and I can confirm, that engine consument even on activation. It did not receive any event (or I overlooked it somehow) when engine entered maintenance mode. I do not understand vdsm well (this is my first visit here) to tell if that's OK. If it's possible, I'd consider to adding ID not having to call getCapabilities on all hosts, but only on one which was just activated... -- To view, visit https://gerrit.ovirt.org/51135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
