Dan Kenigsberg has posted comments on this change. Change subject: v2v: move v2v module to /var/lib/ ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/53084/1/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 23: progress is a number which represent percentage of a single disk copy, Line 24: status is a way to feedback information on the job (init, error etc) Line 25: """ Line 26: Line 27: from collections import namedtuple Missing absolute_import in lib/vdsm/v2v.py Makefile:976: recipe for target 'abs_imports' failed Line 28: from contextlib import closing, contextmanager Line 29: import errno Line 30: import logging Line 31: import os Line 139: return not (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL) : and caps.osversion()['version'].startswith('6')) this piece of code should be dropped, as el6 should not even be considered. then, "import caps" can be avoided. -- To view, visit https://gerrit.ovirt.org/53084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5becf47fb1f139bd246d8853f2c890aa90eb4c7a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
