Francesco Romani has posted comments on this change. Change subject: v2v: move v2v module to site-packages ......................................................................
Patch Set 2: Code-Review+1 (1 comment) looks good, not +2 because of one question inside https://gerrit.ovirt.org/#/c/53084/2/lib/vdsm/Makefile.am File lib/vdsm/Makefile.am: Line 90: @echo " CONFIG $@"; $(PYTHON) $(builddir)/config.py > $@ Line 91: Line 92: install-data-local: \ Line 93: install-data-sample-vdsm-conf Line 94: $(MKDIR_P) $(DESTDIR)$(vdsmrundir)/v2v related? If so, could you please explain why? Line 95: Line 96: uninstall-local: \ Line 97: uninstall-data-sample-vdsm-conf Line 98: -- To view, visit https://gerrit.ovirt.org/53084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5becf47fb1f139bd246d8853f2c890aa90eb4c7a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
