Martin Betak has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/53304/3/tests/vmUtilsTests.py File tests/vmUtilsTests.py: Line 209: self.sem._value > maybe better some new method like trylock I agree that this should not be exposed at all, but then I think for *test* purposes it is more than appropriate to do this with private field access. Just seems to me the least evil. -- To view, visit https://gerrit.ovirt.org/53304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
