Martin Betak has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/53304/3/tests/vmUtilsTests.py File tests/vmUtilsTests.py: Line 209: self.sem._value > It could be appropriate, sure. We are not talking about mistakes, but rathe Done https://gerrit.ovirt.org/#/c/53304/3/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 237: # if we are increasing the bound we need to do this outside of : # context manager otherwise release() would deadlock since it also : # tries to obtain the lock > it is fine if is a note to self. Maybe just mark it as such like Done -- To view, visit https://gerrit.ovirt.org/53304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
