Edward Haas has posted comments on this change. Change subject: net tests: Introduce Router Advertisement with dnsmasq ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54630/1/tests/functional/dhcp.py File tests/functional/dhcp.py: Line 45: self.proc = None Line 46: Line 47: def start(self, interface, dhcp_range_from, dhcp_range_to, Line 48: dhcpv6_range_from=None, dhcpv6_range_to=None, router=None, Line 49: dhcp_enable=True, router_advertisement=False): > I think you cannot express a request for dhcp4+ipv6slaac with the signature Yes, it is a bit messy. looking into it.. Line 50: # --dhcp-authoritative The only DHCP server on network Line 51: # -p 0 don't act as a DNS server Line 52: # --dhcp-option=3,<router> advertise a specific gateway (or None) Line 53: # --dhcp-option=6 don't reply with any DNS servers -- To view, visit https://gerrit.ovirt.org/54630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If770736e899c5e8e5e9086237876b6c0ec74b6ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
