Dan Kenigsberg has posted comments on this change. Change subject: net tests: Introduce Router Advertisement with dnsmasq ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/54630/2/tests/functional/dhcp.py File tests/functional/dhcp.py: Line 66: dhcp_range_to)] Line 67: if dhcpv6_range_from and dhcpv6_range_to: Line 68: command += ['--dhcp-range={0},{1},2m'.format(dhcpv6_range_from, Line 69: dhcpv6_range_to)] Line 70: if ipv6_slaac_prefix: I still do not understand the semantics of this. there's intentionally no _to bound?! What is slaac prefix? and why do you ignore its value when it is not None? Line 71: command += ['--enable-ra'] Line 72: command += ['--dhcp-range={0},slaac,2m'.format(dhcpv6_range_from)] Line 73: Line 74: self.proc = execCmd(command, sync=False) -- To view, visit https://gerrit.ovirt.org/54630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If770736e899c5e8e5e9086237876b6c0ec74b6ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
