Yaniv Bronhaim has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support ......................................................................
Patch Set 7: (1 comment) are you sure? just verified again it and it works as expected. be sure you ran make clean before https://gerrit.ovirt.org/#/c/55517/7/configure.ac File configure.ac: Line 80: ) Line 81: AC_SUBST([PYTHON3_SUPPORT], ["${disable_python3_support}"]) Line 82: AS_IF([test "${disable_python3_support}" = "yes"], Line 83: AC_SUBST([PYTHON3_SUPPORT], ['1']), Line 84: AC_SUBST([PYTHON3_SUPPORT], ['0'])) > this generate the opposite logic. I suggest to how disable can lead to python3_support = true? I really prefer it that way. the falg value is to disable. the env variable says if py3 is enabled or not. this is the clearest way I found Line 85: Line 86: Line 87: AC_ARG_ENABLE( Line 88: [gluster-mgmt], -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
