Yaniv Bronhaim has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/55517/9/contrib/rhev_build.sh File contrib/rhev_build.sh: Line 9: --with-qemu-kvm='qemu-kvm-rhev' \ Line 10: --with-qemu-img='qemu-img-rhev' \ Line 11: --enable-hooks \ Line 12: --disable-gluster-mgmt \ Line 13: --disable-python3-support > Should be --disable-python3 ahhhh thanks ! Line 14: make dist Line 15: Line 16: echo Line 17: echo 'Finish to compile VDSM for RHEV' https://gerrit.ovirt.org/#/c/55517/9/vdsm.spec.in File vdsm.spec.in: Line 13: # Features Line 14: %global with_gluster_mgmt @GLUSTER_MGMT@ Line 15: %global with_hooks @HOOKS@ Line 16: %global with_vhostmd @VHOSTMD@ Line 17: %global support_python3 @PYTHON3_SUPPORT@ > We should use more consistent names. We have: PYTHON3_SUPPORT because PYTHON3 already in use. I can change to with_python3 and --enable-python3 . but if you prefer I can add the "support" to all again Line 18: Line 19: # Glusterfs package version Line 20: %global gluster_version 3.7.1 Line 21: -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
