Martin Betak has posted comments on this change. Change subject: migration: Add retry on full capacity ......................................................................
Patch Set 23: (3 comments) https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py File vdsm/virt/migration.py: PS23, Line 338: retry_timeout > please move as near as possible to its users here I just wanted to avoid the repeated call to config.getint inside a while loop, that's why it is extracted at this level PS23, Line 364: self.log.debug("Migration destination busy. Initiating " : "retry in %d seconds." % retry_timeout) > let's avoid early formatting: Done PS23, Line 673: is_retry_error > I still don't quite get the need of this trivial method, but I don't really Thank you for not minding :-) I really think it conveys the *intent* of the method much more clearly than just inline response.is_error -- To view, visit https://gerrit.ovirt.org/52799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
