Martin Betak has posted comments on this change. Change subject: migration: Add retry on full capacity ......................................................................
Patch Set 23: (2 comments) https://gerrit.ovirt.org/#/c/52799/23/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 124: Line 125: ('max_incoming_migrations', '3', Line 126: 'Maximum concurrent incoming migrations'), Line 127: Line 128: ('migration_retry_timeout', '5', > I would use 10. Completely arbitrary, but sounds better to me:) Done Line 129: 'Time (in sec) to wait before retrying failed migration.'), Line 130: Line 131: ('sys_shutdown_timeout', '120', Line 132: 'Destroy and shutdown timeouts (in sec) before completing the ' https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 69: class MigrationLimitExceeded(RuntimeError): Line 70: """ Line 71: Cannot migrate right now: no resources on destination. Line 72: """ Line 73: # FIXME: should subclass MigrationDestinationSetupError? > so should it or not? Francesco: opinions? Line 74: Line 75: Line 76: class SourceThread(threading.Thread): Line 77: """ -- To view, visit https://gerrit.ovirt.org/52799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
