Martin Betak has posted comments on this change. Change subject: migration: Add retry on full capacity ......................................................................
Patch Set 25: (1 comment) https://gerrit.ovirt.org/#/c/52799/25/vdsm/virt/migration.py File vdsm/virt/migration.py: PS25, Line 401: # Differentiate between general migration failure and a retry > since you need a resubmit, please drop or change this comment. Not sure if I 100% understand your comment. This is part of of the little vdsm 'logic' that should kick in the case SLA mis-schedules a migration and we want to perform a local retry. Not sure how comparison with MigrationDestinationSetupError would clarify this particular piece of code. -- To view, visit https://gerrit.ovirt.org/52799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
