Martin Betak has posted comments on this change. Change subject: migration: Add retry on full capacity ......................................................................
Patch Set 25: (2 comments) https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 353: self._startUnderlyingMigration(time.time()) Line 354: self._finishSuccessfully() Line 355: self._completed = True Line 356: except libvirt.libvirtError as e: Line 357: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_ABORTED: > we already have finishSuccessfully: Done Line 358: self.status = response.error( Line 359: 'migCancelErr', message='Migration canceled') Line 360: raise Line 361: except MigrationLimitExceeded: https://gerrit.ovirt.org/#/c/52799/25/vdsm/virt/migration.py File vdsm/virt/migration.py: PS25, Line 401: # Differentiate between general migration failure and a retry > Sure, I know, but it is pretty obvious from the code that we are going to d Well, having this comment here was Michal's reasoning for removing the is_retry_error helper :-). But I don't mind, I can remove it too. I don't think this is the place in the code to go into great lengths of explaining the retry reasoning. -- To view, visit https://gerrit.ovirt.org/52799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches