Martin Betak has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits ......................................................................
Patch Set 25: (2 comments) https://gerrit.ovirt.org/#/c/53305/25//COMMIT_MSG Commit Message: PS25, Line 11: t is best time for the engine to update them > not sure this is always true. Let's pretend Engine decreases the bound, so yes, this is exactly the behavior intended by the engine since in the host lifecycle as it is defined on the engine there is no suitable event that should trigger this setting. Really setting it *just* before it is used is the best because it applies the new setting lazily and only on those hosts that actually care about it -> so in global effect it saves RPC calls. Not to mention it is resistant to VDSM restarts, because the value is sent each time it is needed thus making VDSM less stateful. https://gerrit.ovirt.org/#/c/53305/25/vdsm/API.py File vdsm/API.py: PS25, Line 592: not incomingLimit > I believe 'incomingLimit is None' is both a bit cheaper and clearer. Done -- To view, visit https://gerrit.ovirt.org/53305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
