Milan Zamazal has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits ......................................................................
Patch Set 25: (2 comments) https://gerrit.ovirt.org/#/c/53305/30/vdsm/API.py File vdsm/API.py: Line 586: params['vmId'] = self._UUID Line 587: result = self.create(params) Line 588: if result['status']['code']: Line 589: self.log.debug('Migration create - Failed') Line 590: # for compatibility with < 4.0 src that could not handle the What if incomingLimit is 0? Line 591: # retry error code Line 592: is_old_source = not incomingLimit Line 593: is_retry_error = response.is_error(result, 'migrateLimit') Line 594: if is_old_source and is_retry_error: https://gerrit.ovirt.org/#/c/53305/25/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 320: -1, -1) # int1, int2 Line 321: raise e Line 322: Line 323: def _update_outgoing_limit(self): Line 324: if self._outgoingLimit: What if 0? Line 325: self.log.debug('Setting outgoing migration limit to %s', Line 326: self._outgoingLimit) Line 327: SourceThread.ongoingMigrations.bound = self._outgoingLimit Line 328: -- To view, visit https://gerrit.ovirt.org/53305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
