Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 93: "%s request." % method) Line 94: Line 95: Line 96: class JsonRpcRequest(object): Line 97: def __init__(self, method, params=(), reqId=None, protect_passwd=True): wow you must stop cuting words. only 2 latters you saved here... passwd is the name of our sasl password configurator Line 98: self.method = method Line 99: if protect_passwd: Line 100: self.params = protect_passwords(params) Line 101: else: -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
