Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 92 Line 93 Line 94 Line 95 Line 96 > I do not see real value in having 2 objects holding the same values but bei The value is not having wrong behavior that will trip users of this code. But I think we have better way - having a stupid object keeping the same info on the both client and server side is ok, the issue is having the protect password in the wrong place - it should be in fromRawObject(). Line 122 Line 123 Line 124 Line 125 Line 126 Decoding should be done here - before creating the instance, not in init. This is the first point in the server side that you have the params dict - at this point you should protect password to prevent accidental logging. -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
