Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side ......................................................................
Patch Set 3: Trying again: Asking the user of this code to send protect_password=False for client connection is abusing the user of this code. The real problem is trying to protect passwords in the wrong place. The correct place to do this is when decoding a message from the wire. If we add the wrong fix now, changing the api, hosted engine guys will add this flag to their code, and then we can never remove it, or we will cause them major pain when we remove it. -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
