Dan Kenigsberg has posted comments on this change. Change subject: bridge: usage of yaml schema ......................................................................
Patch Set 23: Code-Review-1 (3 comments) two nits and one worrying question https://gerrit.ovirt.org/#/c/54528/23/lib/api/schemaapi.py File lib/api/schemaapi.py: PS23, Line 83: param naming nit: in python (and elsewhere in Vdsm) this is commonly called "arg", not "param") https://gerrit.ovirt.org/#/c/54528/23/lib/vdsm/rpc/Bridge.py File lib/vdsm/rpc/Bridge.py: Line 82: ret = ret + (argobj[arg],) Line 83: else: Line 84: if len(defaultValues) > 0: Line 85: ret = ret + (defaultValues[0],) Line 86: defaultValues = defaultValues[1:] wouldn't this copy the special-named "no-default" verbatim? Line 87: elif arg in argobj: Line 88: ret = ret + (argobj[arg],) Line 89: return ret Line 90: PS23, Line 119: class_name I love pep8, but this change better be in its own patch -- To view, visit https://gerrit.ovirt.org/54528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
