Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema ......................................................................
Patch Set 24: (2 comments) https://gerrit.ovirt.org/#/c/54528/24/lib/api/schemaapi.py File lib/api/schemaapi.py: PS24, Line 84: param > nit: param->arg Done https://gerrit.ovirt.org/#/c/54528/24/lib/vdsm/rpc/Bridge.py File lib/vdsm/rpc/Bridge.py: PS24, Line 80: defaultArgs > nit: create a fronzenset of default args outside of `for arg`. I hate needl Will explore -- To view, visit https://gerrit.ovirt.org/54528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
