Yaniv Bronhaim has posted comments on this change. Change subject: Adding report_stats to host.api ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/56880/3/lib/vdsm/common/host/api.py File lib/vdsm/common/host/api.py: PS3, Line 103: report.send > How many messages/udp packets code 103 - 109 is generating? Is it 1 or 6? 6 https://gerrit.ovirt.org/#/c/56880/10/lib/vdsm/host/api.py File lib/vdsm/host/api.py: Line 85 Line 86 Line 87 Line 88 Line 89 > This does not blong to host.api - why not keep it in host.stats? so also get_stats should move there as well.. we intend to make host.api as the external interface for all host package methods. which should include host.get_stats_dict host.report_stats host.get_caps - as far as I see it now https://gerrit.ovirt.org/#/c/56880/1/lib/vdsm/virt/sampling.py File lib/vdsm/virt/sampling.py: PS1, Line 551: d_last = se > We need to send raw, complete data. complete - each report in new request in new uds packet. I don't see any problem with that -- To view, visit https://gerrit.ovirt.org/56880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
