Francesco Romani has posted comments on this change. Change subject: Adding report_stats to host.api ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/58661/9/lib/vdsm/host/api.py File lib/vdsm/host/api.py: Line 133: Line 134: reports.send(report) Line 135: except KeyError as e: Line 136: logging.exception('Report host stat failed to report key: %s' % Line 137: (e.args[0],)) > e.args[0] not needed, and bad idea in general, we should not make assumptio +1 Line 138: Line 139: Line 140: def _readSwapTotalFree(): Line 141: meminfo = utils.readMemInfo() -- To view, visit https://gerrit.ovirt.org/58661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie65c865669422b7652b028492b1380157fc5e177 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
