Ondřej Svoboda has posted comments on this change.

Change subject: net: don't accept nameservers on a non-default network
......................................................................


Patch Set 7: Verified+1

No failed unit tests on EL7 and 1 failed on F24, though it is not a regression. 
'del_neigh' is not caught by test_events_keys (tests/network/link_test.py).

Old functional tests have seen no regression. test_ipv4_default_route and 
testSetupNetworksEmergencyDevicesCleanup(Bond|Vlan)Overwrite fail on both 
platforms. Additionally, tests using dhclient directly (5) result in errors on 
F24 because the '-timeout' parameter has been renamed to '--timeout'.

Among new functional tests, test_add_net_based_on_nic fails in operstate check 
but again, it is no regression: AssertionError: u'DOWN' not found in ('UP', 
'UNKNOWN')

The newly added functional tests work fine.

-- 
To view, visit https://gerrit.ovirt.org/62167
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42a5d5a7aeb1169d510a3de8d04645efbab505e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Edward Haas <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to