Dan Kenigsberg has submitted this change and it was merged. Change subject: net: don't accept nameservers on a non-default network ......................................................................
net: don't accept nameservers on a non-default network Currently, only the default/management network (the one with the default route) may be used to set nameservers, for reasons given below. Previously, an attempt to set nameservers through a non-default network would be ignored silently. While it may be possible in the future to refine this design, the configuration of nameservers is now viewed as a per-host task, in which it makes sense to use the default network. Change-Id: Ib42a5d5a7aeb1169d510a3de8d04645efbab505e Signed-off-by: Ondřej Svoboda <[email protected]> Reviewed-on: https://gerrit.ovirt.org/62167 Reviewed-by: Edward Haas <[email protected]> Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/network/api.py A lib/vdsm/network/ip/validator.py M tests/network/func_dns_test.py 3 files changed, 52 insertions(+), 2 deletions(-) Approvals: Ondřej Svoboda: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62167 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib42a5d5a7aeb1169d510a3de8d04645efbab505e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
