Dan Kenigsberg has posted comments on this change. Change subject: net test: Clean lease files on setup-cleanup ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/63089/1/tests/network/netfunctestlib.py File tests/network/netfunctestlib.py: Line 426: nics_used += attr['nics'] Line 427: for nic in nics_used: Line 428: utils.rmFile(IFCFG_PREFIX + nic) Line 429: Line 430: # Cleanup lease files iproute2 configurator is using iface==network's toplevel device, which is NOT the network name incase of a bridgeless network. No huge deal (since iproute2 is already broken, but should be noted here as TODO, or fixed right away) Line 431: for iface in NETSETUP: Line 432: utils.rmFile(dhclient.LEASE_FILE.format('', iface)) Line 433: utils.rmFile(dhclient.LEASE_FILE.format('6', iface)) Line 434: for iface in BONDSETUP: -- To view, visit https://gerrit.ovirt.org/63089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
