Edward Haas has posted comments on this change. Change subject: net test: Clean lease files on setup-cleanup ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/63089/1/tests/network/netfunctestlib.py File tests/network/netfunctestlib.py: Line 426: nics_used += attr['nics'] Line 427: for nic in nics_used: Line 428: utils.rmFile(IFCFG_PREFIX + nic) Line 429: Line 430: self._cleanup_lease_files(set(NETSETUP) | set(BONDSETUP) | sb_ifaces) > iproute2 configurator is using iface==network's toplevel device, which is N Done Line 431: Line 432: return status, msg Line 433: Line 434: def _cleanup_lease_files(self, ifaces): https://gerrit.ovirt.org/#/c/63089/8/tests/network/netfunctestlib.py File tests/network/netfunctestlib.py: Line 430: self._cleanup_lease_files(set(NETSETUP) | set(BONDSETUP) | sb_ifaces) Line 431: Line 432: return status, msg Line 433: Line 434: def _cleanup_lease_files(self, ifaces): > it is the same for ifcfg bridgeless networks, isn't it? Done Line 435: for iface in ifaces: Line 436: utils.rmFile(dhclient.LEASE_FILE.format('', iface)) Line 437: utils.rmFile(dhclient.LEASE_FILE.format('6', iface)) Line 438: -- To view, visit https://gerrit.ovirt.org/63089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
