Yaniv Bronhaim has posted comments on this change. Change subject: sos: replace dumpStorageTable with dump_volume_chains ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/62628/5/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in: Line 57 Line 58 Line 59 Line 60 Line 61 how is this removal related to the use of dump-volume-chains? Line 126: self.collectExtOutput("/usr/bin/iostat") Line 127: self.collectExtOutput("/sbin/iscsiadm -m node") Line 128: self.collectExtOutput("/sbin/iscsiadm -m session") Line 129: Line 130: with closing(jsonrpcvdscli.connect()) as cli: this change can be done in different patch Line 131: self.addObjectAsFile(cli.getVdsCapabilities(), "getVdsCapabilities") Line 132: self.addObjectAsFile(cli.getVdsStats(), "getVdsStats") Line 133: self.addObjectAsFile(cli.getAllVmStats(), "getAllVmStats") Line 134: self.addObjectAsFile(cli.list(), "list") -- To view, visit https://gerrit.ovirt.org/62628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marina Kalinin <m...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org