Ramesh N has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/62773/4/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 331: Line 332: rc, out, err = commands.execCmd([_restoreconCommandPath.cmd, Line 333: '-Rv', mountPoint]) Line 334: if rc: Line 335: raise ge.GlusterHostFailedToRunRestorecon(mountPoint, rc, out, err) > Isn't there a way to scan for the brick list ? Only way is to scan through the mount points and if anything mounted on the bricks default mount point then consider that as brick. But it is not reliable since user can give any mount point while creating brick. In some cases user may have manually created these bricks and mounted manually. Also vdsm doesn't know the default brick mount point. It is maintained in engine config. Line 336: -- To view, visit https://gerrit.ovirt.org/62773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
