Adam Litke has posted comments on this change. Change subject: monitor: Rename storage domain monitor threads ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/63524/4/vdsm/storage/monitor.py File vdsm/storage/monitor.py: PS4, Line 256: sdUUID[:7] It's theoretically possible to have a pair of domains with matching short uuids. What happens then? Can different threads have the same name? -- To view, visit https://gerrit.ovirt.org/63524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org