Nir Soffer has posted comments on this change. Change subject: monitor: Rename storage domain monitor threads ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/63524/4/vdsm/storage/monitor.py File vdsm/storage/monitor.py: Line 252: class MonitorThread(object): Line 253: Line 254: def __init__(self, sdUUID, hostId, interval, changeEvent, checker): Line 255: self.thread = concurrent.thread(self._run, logger=log.name, Line 256: name="monitor/" + sdUUID[:7]) > Yes, name is not unique. Today all threads are named (in htop and ps) "vdsm To minimize the chance of collusion, but avoid too long thread names in vdsm logs, we can use: "monitor/" + sdUUID[:18] The name will look like this in vdsm logs: monitor/95430c8c-bbfc-4811 And like this in system tools (15 chars limit): monitor/95430c8 We can do the same for other short uuids in the next patches. Line 257: self.stopEvent = threading.Event() Line 258: self.domain = None Line 259: self.sdUUID = sdUUID Line 260: self.hostId = hostId -- To view, visit https://gerrit.ovirt.org/63524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
