Nir Soffer has posted comments on this change. Change subject: Define the StorageDomain.reduce API ......................................................................
Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/62853/7/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 8228: type: *UUID Line 8229: Line 8230: - description: A block device GUID Line 8231: name: guid Line 8232: type: string I would like to have new style api similar to copy_data. This is also more correct as this operation is not really performed on the storage domain object, but passed to irs anyway, and run in a job. Line 8233: Line 8234: StorageDomain.resizePV: Line 8235: added: '3.6' Line 8236: description: Resize PV will cause the PV to use the entire size of the https://gerrit.ovirt.org/#/c/62853/7/vdsm/API.py File vdsm/API.py: Line 1078: def extend(self, storagepoolID, devlist, force=False): Line 1079: return self._irs.extendStorageDomain(self._UUID, storagepoolID, Line 1080: devlist, force) Line 1081: Line 1082: def reduce(self, jobID, guid): Please use the same name in all layers (jobID or jobUUID or job_id). Line 1083: return self._irs.reduceStorageDomain(jobID, self._UUID, guid) Line 1084: Line 1085: def resizePV(self, storagepoolID, guid): Line 1086: return self._irs.resizePV(self._UUID, storagepoolID, guid) https://gerrit.ovirt.org/#/c/62853/7/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 747: """ Line 748: Reduce a block-based Storage Domain by removing a device from it. Line 749: Line 750: :param UUID: The UUID of the job. Line 751: :type UUID: UUID UUID -> jobUUID Line 752: :param sdUUID: The UUID of the storage domain that owns the PV. Line 753: :type sdUUID: UUID Line 754: :param guid: A block device GUID Line 755: :type guid: str -- To view, visit https://gerrit.ovirt.org/62853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
