Nir Soffer has posted comments on this change. Change subject: logging: add and use new devel logger ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 135 Line 136 Line 137 Line 138 Line 139 This is the major issue here - the application using this library does not have any control over warnings. Line 142: Line 143: Line 144: _devel.warning( Line 145: "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please use " Line 146: "vdsm.jsonrpcvdscli") One issue with this - vdscli is a library used outside vdsm - users of this library must use logging level of ERROR, or configure the devel logger, otherwise they will see this warning in their logs, or worse in their stderr. I think this change is better then what we had before, but in general we should avoid such warnings in library code. Line 147: Line 148: Line 149: if __name__ == '__main__': Line 150: print('connecting to %s:%s ssl %s ts %s' % ( -- To view, visit https://gerrit.ovirt.org/62209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
