Nir Soffer has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 138
Line 139
Line 140
Line 141
Line 142
> I don't see any use for leaving the warning here that way. the all idea was
This will show warnings if you run python with warnings enabled.

See https://docs.python.org/2/using/cmdline.html#cmdoption-W


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Irit Goihman <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to