Nir Soffer has posted comments on this change.
Change subject: vdscli: do not use the warnings module
......................................................................
Patch Set 1: Code-Review-1
Logging to secret logger in a library means the log would show in the program
importing this module. This is not unacceptable for existing application, so I
think we should avoid this.
Currently applications which do not configure logging will show this:
No handlers could be found for logger "devel"
Application like vdsm-tool and hosted-engine will probably show the log to
standard error, not acceptable as this is log for developers, not users.
--
To view, visit https://gerrit.ovirt.org/64117
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3481538292cf1a77329faf3d7701767b6e0bfd60
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
