Adam Litke has posted comments on this change. Change subject: sdm: Introduce new SDM.merge verb ......................................................................
Patch Set 2: (1 comment) Let's discuss the API we want before proceeding. https://gerrit.ovirt.org/#/c/64196/2/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS2, Line 9919: CopyDataDivEndpoint Great for code reuse but this means we're supplying the sd and image twice when all we truly need is: job_id, sd_id, img_id, base_vol_id, top_vol_id Another concern is the .locks property of CopyDataDivEndpoint. Are you sure you want the same set of locks (including the volume lease? Maybe so but I expect there could be some issues with deciding whether locks are shared or exclusive. I think it's better to use bare uuids in this verb and build your own lock list to pass to guarded.context directly in the verb itself. -- To view, visit https://gerrit.ovirt.org/64196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96d57a5b9f21153ce1de2cd5619c7f9f78bbe75b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
