Adam Litke has posted comments on this change. Change subject: storage: Use mismatched_vm_conf_disk workaround in copy_data ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/64231/1/vdsm/storage/sdm/api/copy_data.py File vdsm/storage/sdm/api/copy_data.py: Line 62 Line 63 Line 64 Line 65 Line 66 > If we add a is_bad_vm_conf() method to DivEndpoint: I am not splitting the test from the fix in workaround.detect_format anymore. Therefore, I'll go back to putting this inside CopyDataDIVEndpoint.qemu_format. Line 119: if workarounds.mismatched_vm_conf_disk(self._vol): Line 120: self._qemu_format = qemuimg.FORMAT.RAW Line 121: else: Line 122: self._qemu_format = sc.fmt2str(self._vol.getFormat()) Line 123: return self._qemu_format > We need this check only for the source image, and then we want to apply the I agreed with you earlier but in reality I think it needs to be here. workarounds.detect_format takes volume object but even if we changed it to accept the three scalar values needed to make the decision (vdsm md format, path, and size) this logic is not endpoint agnostic. The only object which should supply a vdsm volume metadata value is a DIVEndpoint. For this reason, I want to keep it here in the property since it is relevant only for vdsm volume source endpoints. If we make the assumption that we are not changing the format on the fly when we copy then we will just use this value for the source and destination format value when calling qemuimg.convert. Line 124: Line 125: @property Line 126: def backing_path(self): Line 127: parent_vol = self._vol.getParentVolume() -- To view, visit https://gerrit.ovirt.org/64231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecfd3e0fd5923e9a333379ab21e01c9b12def78c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
