Nir Soffer has posted comments on this change. Change subject: [WIP] core: Expose API for qemuimg commit ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py File tests/qemuimg_test.py: Line 363: op = qemuimg.commit(top) Line 364: op.wait_for_completion() Line 365: Line 366: # top should not change after commit Line 367: qemu_pattern_verify(top, qemuimg.FORMAT.RAW, '0', 0xf1) > Issues: This actually tests nothing, since top will show the data from base even if it was empty. We can verify that top size did not change after the operation. Line 368: Line 369: # base now should include original data and top's data Line 370: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf2) Line 371: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '512', 0xf1) -- To view, visit https://gerrit.ovirt.org/64222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
