Nir Soffer has posted comments on this change. Change subject: [WIP] core: Expose API for qemuimg commit ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/64222/4/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 197: # If base volume is not provided, qemuimg commit will empty the top Line 198: # volume after the operation has succeeded. Providing '-d' option Line 199: # will cause qemuimg commit not to empty the top volume. Note that Line 200: # if a backing chain is provided, i.e. a base volume is provided, Line 201: # '-d' is always implied. This comment is repeating what we can read in the manual twice. What is missing here and is more important, is why we don't want to empty the image - we may need to wipe the top volume before deleting it, and emptying it may leave the data on the the underlying storage (qemu probably mark sectors as zero instead of wiping the data). Line 202: cmd.append("-d") Line 203: Line 204: if topFormat: Line 205: cmd.extend(("-f", str(topFormat))) -- To view, visit https://gerrit.ovirt.org/64222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
