Nir Soffer has posted comments on this change. Change subject: qemuimg: Add qcow_compat optional parameter. ......................................................................
Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/64169/23/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 323: raise ValueError("not a JSON object") Line 324: return obj Line 325: Line 326: Line 327: def _validate_qcow2_compat(qcow2_value): Can you rename qcow2_value to value? This a helper to validate specific value, the name make it very clear. In the context of this 6 line helper, there is only one value, we don't have to give it a specific name. Line 328: if qcow2_value is None: Line 329: qcow2_value = default_qcow2_compat() Line 330: return qcow2_value Line 331: if qcow2_value not in _QCOW2_COMPAT_SUPPORTED: -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org