Nir Soffer has posted comments on this change. Change subject: qemuimg: Add qcow_compat optional parameter. ......................................................................
Patch Set 25: (1 comment) https://gerrit.ovirt.org/#/c/64169/25/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 326: Line 327: def _validate_qcow2_compat(value): Line 328: if value is None: Line 329: value = default_qcow2_compat() Line 330: return value Better: if value is None: return default_qcow2_compat() Line 331: if value not in _QCOW2_COMPAT_SUPPORTED: Line 332: raise ValueError("Invalid compat version '%r'" % value) -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
