Liron Aravot has posted comments on this change. Change subject: StorageDomain.getInfo - report lvm metadata device for block sd ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/64433/4/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 1343: return pv Line 1344: except AttributeError: Line 1345: pass Line 1346: Line 1347: raise se.CannotGetVGMetadataPV(vgName) Do we want to have a general exception or to use that specific one? Line 1348: Line 1349: Line 1350: def _isMetadataPv(pv): Line 1351: return pv.mda_used_count == '2' -- To view, visit https://gerrit.ovirt.org/64433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a7763d2ab7d796be633ecd69f661cba96e29dde Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
