Liron Aravot has posted comments on this change.

Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64433/4/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:

Line 556:                 pvs.update(reloaded)
Line 557:         return pvs.values()
Line 558: 
Line 559:     def getVgPvNames(self, vgName):
Line 560:         return self.getVg(vgName).pv_name
> We can work on refactoring this class later if you think such helper is nee
Well, i use this method in the following patch - so i assume i'll return it 
(see line 913 in https://gerrit.ovirt.org/#/c/63270/8/vdsm/storage/lvm.py)
Line 561: 
Line 562:     def getVgPvs(self, vgName):
Line 563:         stalepvs = []
Line 564:         vgpvs = []


-- 
To view, visit https://gerrit.ovirt.org/64433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a7763d2ab7d796be633ecd69f661cba96e29dde
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to