Nir Soffer has posted comments on this change.

Change subject: protocoldetector: Fix random double close
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetector.py:

Line 206:         self._handlers.append(detector)
Line 207: 
Line 208:     def stop(self):
Line 209:         self.log.debug("Stopping Acceptor")
Line 210:         self._acceptor.close()
> what is your definition of broken because it seems I have a different one.
Here is another failure:

 22:59:10 ======================================================================
 22:59:10 ERROR: test_detect_uppercase(False) 
(protocoldetectorTests.AcceptorTests)
 22:59:10 ----------------------------------------------------------------------
 22:59:10 Traceback (most recent call last):
 22:59:10   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/protocoldetectorTests.py",
 line 113, in tearDown
 22:59:10     self.acceptor.stop()
 22:59:10   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/lib/vdsm/protocoldetector.py",
 line 211, in stop
 22:59:10     self._acceptor.close()
 22:59:10   File "/usr/lib64/python2.7/asyncore.py", line 407, in close
 22:59:10     self.del_channel()
 22:59:10   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/lib/yajsonrpc/betterAsyncore.py",
 line 137, in del_channel
 22:59:10     asyncore.dispatcher.del_channel(self, map)
 22:59:10   File "/usr/lib64/python2.7/asyncore.py", line 292, in del_channel
 22:59:10     del map[fd]
 22:59:10 KeyError: 63
 22:59:10 -------------------- >> begin captured logging << --------------------
 22:59:10 2016-10-12 22:56:33,013 INFO    (MainThread) 
[vds.MultiProtocolAcceptor] Listening at 127.0.0.1:39101 (protocoldetector:178)
 22:59:10 2016-10-12 22:56:33,014 DEBUG   (MainThread) 
[vds.MultiProtocolAcceptor] Adding detector <protocoldetectorTests.Echo object 
at 0x7f2c4a5262d0> (protocoldetector:205)
 22:59:10 2016-10-12 22:56:33,014 DEBUG   (MainThread) 
[vds.MultiProtocolAcceptor] Adding detector <protocoldetectorTests.Uppercase 
object at 0x7f2c4a526590> (protocoldetector:205)
 22:59:10 2016-10-12 22:56:33,016 INFO    (Thread-182) 
[ProtocolDetector.AcceptorImpl] Accepting connection from 127.0.0.1:33770 
(protocoldetector:71)
 22:59:10 2016-10-12 22:56:33,016 DEBUG   (Thread-182) 
[ProtocolDetector.Detector] Using required_size=9 (protocoldetector:84)
 22:59:10 2016-10-12 22:56:33,017 INFO    (Thread-182) 
[ProtocolDetector.Detector] Detected protocol uppercase from 127.0.0.1:33770 
(protocoldetector:120)
 22:59:10 2016-10-12 22:56:33,068 DEBUG   (MainThread) 
[vds.MultiProtocolAcceptor] Stopping Acceptor (protocoldetector:209)
 22:59:10 --------------------- >> end captured logging << ---------------------

Piotr, we need to fix this code soon.
Line 211:         self._reactor.stop()
Line 212: 
Line 213: 
Line 214: class _CannotDetectProtocol(Exception):


-- 
To view, visit https://gerrit.ovirt.org/65187
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cec41c4baebcc620b70e19e62febed5dc9c542d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to